Skip to content

Fix golangci lint url#1067

Merged
ske-prow[bot] merged 2 commits intomainfrom
fixGolangciLintUrl
May 7, 2026
Merged

Fix golangci lint url#1067
ske-prow[bot] merged 2 commits intomainfrom
fixGolangciLintUrl

Conversation

@dergeberl
Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.

This PR also directly address new lint findings with that new version of golang and goconst.

This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.

/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label May 7, 2026
@dergeberl dergeberl requested a review from a team May 7, 2026 14:10
@ske-prow ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2026
@ske-prow ske-prow Bot assigned xoxys May 7, 2026
@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 7, 2026

LGTM label has been added.

DetailsGit tree hash: e4cd6087e974f58a51d37870fc682bf724b9815d

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xoxys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2026
@ske-prow ske-prow Bot merged commit f6a6c84 into main May 7, 2026
3 checks passed
@ske-prow ske-prow Bot deleted the fixGolangciLintUrl branch May 7, 2026 14:14
@stackit-ske
Copy link
Copy Markdown

@dergeberl: new pull request created: #1068

Details

In response to this:

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.

This PR also directly address new lint findings with that new version of golang and goconst.

This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.

/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske
Copy link
Copy Markdown

@dergeberl: new pull request created: #1069

Details

In response to this:

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.

This PR also directly address new lint findings with that new version of golang and goconst.

This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.

/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske
Copy link
Copy Markdown

@dergeberl: new pull request created: #1070

Details

In response to this:

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.

This PR also directly address new lint findings with that new version of golang and goconst.

This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.

/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske
Copy link
Copy Markdown

@dergeberl: new pull request created: #1071

Details

In response to this:

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.

This PR also directly address new lint findings with that new version of golang and goconst.

This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.

/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants